Add support for python-magic-bin DLL#280
Closed
Dasc3er wants to merge 1 commit intoahupp:masterfrom
Dasc3er:master
Closed
Add support for python-magic-bin DLL#280Dasc3er wants to merge 1 commit intoahupp:masterfrom Dasc3er:master
Dasc3er wants to merge 1 commit intoahupp:masterfrom
Dasc3er:master
Conversation
Author
|
Closing as there seems to be no interest in merging. Refer to #249 for original. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround for the discovery of libmagic DLL provided by python-magic-bin in Windows.
In this way, the latest version of python-magic can be used in combination with python-magic-bin to work in Windows seamlessly for end users, as there is no dependency on outdated code from python-magic-bin.
Based on PR #249 by @av-gantimurov, created to allow fast merge
Related issue: #248